Skip to content

Commit

Permalink
Skip numba test that fails on ARM (#14702)
Browse files Browse the repository at this point in the history
Nightly jobs have been [failing](https://github.com/rapidsai/cudf/actions/runs/7382855293/job/20083184931) with a numba segfault.

This appears to be a longstanding issue with numba on aarch64 fixed by numba/llvmlite#1009. Technically, the issue exists already in our tests, but it appears that changes from numba 0.58 make the conditions for the issue to occur much more likely, hence the failures occurring after removing the numba 0.58 version constraint recently. The issue should be fixed in numba 0.59.

For now however we should skip things so that nightlies can be fixed.

Authors:
  - https://github.com/brandon-b-miller

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #14702
  • Loading branch information
brandon-b-miller authored Jan 5, 2024
1 parent fab5af2 commit b83ab43
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ exclude = [
# TODO: Remove this in a follow-up where we fix __all__.
"__init__.py",
]
line-length = 79
line-length = 88

[tool.ruff.per-file-ignores]
# Lots of pytest implicitly injected attributes in conftest-patch.py
Expand Down
5 changes: 4 additions & 1 deletion python/cudf/cudf_pandas_tests/test_cudf_pandas.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES.
# SPDX-FileCopyrightText: Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES.
# All rights reserved.
# SPDX-License-Identifier: Apache-2.0

Expand Down Expand Up @@ -668,6 +668,9 @@ def test_rolling_win_type():
tm.assert_equal(result, expected)


@pytest.mark.skip(
reason="Requires Numba 0.59 to fix segfaults on ARM. See https://github.com/numba/llvmlite/pull/1009"
)
def test_rolling_apply_numba_engine():
def weighted_mean(x):
arr = np.ones((1, x.shape[1]))
Expand Down

0 comments on commit b83ab43

Please sign in to comment.