Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RMM allocators #12861

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Update RMM allocators #12861

merged 1 commit into from
Feb 28, 2023

Conversation

pentschev
Copy link
Member

Following rapidsai/rmm#1221, RMM allocators now live under the rmm.allocators submodule and using old paths causes warnings to be raised. This change updates to the new submodule and prevents such warnings.

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@pentschev
Update RMM allocators
ea4aa9a 
Following rapidsai/rmm#1221, RMM allocators now
live under the `rmm.allocators` submodule and using old paths causes
warnings to be raised. This change updates to the new submodule and
prevents such warnings.
@pentschev pentschev requested a review from a team as a code owner February 28, 2023 08:50
@pentschev
Copy link
Member Author

cc @wence-

@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 28, 2023
@pentschev pentschev added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change deprecation improvement Improvement / enhancement to an existing function labels Feb 28, 2023
@wence-
Copy link
Contributor

wence- commented Feb 28, 2023

I had opened #12842, but the change is identical here, so approving.

@wence-
Copy link
Contributor

wence- commented Feb 28, 2023

/merge

@wence- wence- mentioned this pull request Feb 28, 2023
Closed
3 tasks
@pentschev
Copy link
Member Author

Grr, sorry for that Lawrence, I had searched for open PRs with "RMMNumbaManager" and GH didn't return any results. Apologies for that.

@wence- wence- mentioned this pull request Feb 28, 2023
Merged
@rapids-bot rapids-bot bot merged commit a7e5092 into rapidsai:branch-23.04 Feb 28, 2023
@pentschev pentschev deleted the update-rmm-allocators branch November 19, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pentschev @wence-