Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to rapidsai/rmm#1221 which moves allocator callbacks #5249

Merged

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Feb 24, 2023

The allocator callbacks now live in their own submodules (so that RMM does not, for example, import pytorch unless required) and so must be explicitly imported.

The allocator callbacks now live in their own submodules (so that RMM
does not, for example, import pytorch unless required) and so must be
explicitly imported.
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 24, 2023
@wence- wence- marked this pull request as ready for review February 28, 2023 09:27
@wence- wence- requested a review from a team as a code owner February 28, 2023 09:27
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 28, 2023
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csadorf csadorf added the 3 - Ready for Review Ready for review by team label Feb 28, 2023
@wence-
Copy link
Contributor Author

wence- commented Feb 28, 2023

Warnings will still appear in the test suite until cudf nightlies come out tomorrow (with rapidsai/cudf#12861)

@wence-
Copy link
Contributor Author

wence- commented Mar 6, 2023

I think this is ready to merge...

@wphicks
Copy link
Contributor

wphicks commented Mar 6, 2023

/merge

@rapids-bot rapids-bot bot merged commit d071e21 into rapidsai:branch-23.04 Mar 6, 2023
@wence- wence- deleted the wence/fix/rmm-allocator-move branch March 6, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants