Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to rapidsai/rmm#1221 which moves allocator callbacks #12842

Closed
wants to merge 1 commit into from
Closed

Adapt to rapidsai/rmm#1221 which moves allocator callbacks #12842

wants to merge 1 commit into from

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Feb 24, 2023

Description

The allocator callbacks now live in their own submodules (so that RMM does not, for example, import pytorch unless required) and so must be explicitly imported.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
Adapt to rapidsai/rmm#1221 which moves allocator callbacks
2e0af3d 
The allocator callbacks now live in their own submodules (so that RMM
does not, for example, import pytorch unless required) and so must be
explicitly imported.
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 24, 2023
@wence- wence- self-assigned this Feb 24, 2023
@wence- wence- added non-breaking Non-breaking change RMM improvement Improvement / enhancement to an existing function labels Feb 24, 2023
@wence- wence- mentioned this pull request Feb 28, 2023
Merged
3 tasks
@wence-
Copy link
Contributor Author

wence- commented Feb 28, 2023

Superseded by #12861

@wence- wence- closed this Feb 28, 2023
@wence- wence- deleted the wence/fix/rmm-allocator-move branch February 28, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wence- wence-

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wence-