-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix groupby gtests coded in namespace cudf::test #12784
Merged
rapids-bot
merged 4 commits into
rapidsai:branch-23.04
from
davidwendt:fix-gtest-ns-groupby1
Feb 16, 2023
Merged
Fix groupby gtests coded in namespace cudf::test #12784
rapids-bot
merged 4 commits into
rapidsai:branch-23.04
from
davidwendt:fix-gtest-ns-groupby1
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Currently a work in progress
libcudf
Affects libcudf (C++/CUDA) code.
tech debt
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Feb 15, 2023
I know there are a lot of files here. They are mostly namespace changes. Here are some exceptions:
|
davidwendt
added
3 - Ready for Review
Ready for review by team
and removed
2 - In Progress
Currently a work in progress
labels
Feb 16, 2023
ttnghia
approved these changes
Feb 16, 2023
vuule
reviewed
Feb 16, 2023
vuule
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a PR. Were you able to automate at least some of these changes?
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
…ild (#12799) Re-enable groupby with `std` and `var` aggregations that were disabled for Debug builds due to a runtime issue. Retesting with nvcc 11.5, the error is no longer present so the code and the gtests have been re-enabled. Found while working on PR #12784 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - Mike Wilson (https://github.com/hyperbolic2346) - Vyas Ramasubramani (https://github.com/vyasr) URL: #12799
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
Remove the `using namespace cudf;` from the top of the source file to make it easier to follow. Seemed an unnecessary usage and violated the spirit of #12784 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) - Vyas Ramasubramani (https://github.com/vyasr) URL: #12985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
CMake
CMake build issue
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
GROUPBY_TEST
gtests source files coded in namespacecudf::test
Additional creates a
groupby_test_util.cpp
for utilities rather than inlining the utilities into all 33 source files.The groupby tests for aggregations
std
andvar
are also not compiled for Debug builds.This changes those to compile but be runtime disabled to make them more noticeable in a Debug test run.
Reference #11734
Checklist