Enable groupby std and variance aggregation types in libcudf Debug build #12799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
|
@davidwendt is this PR in draft because you were planning to make additional changes here? Otherwise I'm happy to approve, this looks good to me. |
|
Mostly because I'm away for the weekend and did not want to require reviews while I was away.😀 |
davidwendt
added
3 - Ready for Review
bdice
approved these changes
Feb 21, 2023
hyperbolic2346
approved these changes
Feb 21, 2023
vyasr
approved these changes
Feb 21, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-enable groupby with
stdandvaraggregations that were disabled for Debug builds due to a runtime issue.Retesting with nvcc 11.5, the error is no longer present so the code and the gtests have been re-enabled.
Found while working on PR #12784
Checklist