Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework gtests SequenceTest to remove using namepace cudf #12985

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Rework gtests SequenceTest to remove using namepace cudf #12985

merged 2 commits into from
Mar 22, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Mar 21, 2023 •
edited
Loading

Description

Remove the using namespace cudf; from the top of the source file to make it easier to follow. Seemed an unnecessary usage and violated the spirit of #12784

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 21, 2023
@davidwendt davidwendt self-assigned this Mar 21, 2023
@davidwendt davidwendt requested a review from a team as a code owner March 21, 2023 21:46
@davidwendt davidwendt requested review from vyasr and elstehle March 21, 2023 21:46
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d9ad58c into rapidsai:branch-23.04 Mar 22, 2023
@davidwendt davidwendt deleted the gtest-ns-sequence branch March 22, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @vyasr @bdice @ttnghia