Fix cmake error after upgrading to Arrow 9 #11513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
ttnghia
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11513 +/- ##
===============================================
Coverage ? 86.48%
===============================================
Files ? 145
Lines ? 22844
Branches ? 0
===============================================
Hits ? 19756
Misses ? 3088
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bdice
reviewed
Aug 11, 2022
cpp/cmake/thirdparty/get_arrow.cmake
Outdated
| @@ -121,6 +121,7 @@ function(find_and_configure_arrow VERSION BUILD_STATIC ENABLE_S3 ENABLE_ORC ENAB | |||
| "ARROW_GRPC_USE_SHARED ${ARROW_BUILD_SHARED}" | |||
| "ARROW_PROTOBUF_USE_SHARED ${ARROW_BUILD_SHARED}" | |||
| "ARROW_ZSTD_USE_SHARED ${ARROW_BUILD_SHARED}" | |||
| "xsimd_SOURCE BUNDLED" | |||
There was a problem hiding this comment.
What is the default value here?
It looks like when the dependency source is resolved, it may have an AUTO option that attempts to find the package and falls back to the bundled copy.
There was a problem hiding this comment.
AUTO also works on my local machine. I'm going to change this to AUTO.
bdice
approved these changes
Aug 11, 2022
robertmaynard
approved these changes
Aug 11, 2022
galipremsagar
added
5 - Ready to Merge
|
@gpucibot merge |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to Arrow 9 (#11507), some systems experience a cmake issue:
This may be due to the configurations for Arrow is looking for a local installation of
xsimd, which does not exist or the installation path is not provided.This PRs adds an option to cudf cmake, specifying that Arrow should handle
xsimdby itself.