Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Upgrade to arrow-9.x #11507

Merged
merged 6 commits into from
Aug 10, 2022
Merged

[REVIEW] Upgrade to arrow-9.x #11507

merged 6 commits into from
Aug 10, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Aug 10, 2022 •
edited
Loading

Description

This PR upgrades arrow to 9.x in cudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this Aug 10, 2022
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 10, 2022
@github-actions github-actions bot added CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. labels Aug 10, 2022
@github-actions github-actions bot added the gpuCI label Aug 10, 2022
@galipremsagar galipremsagar mentioned this pull request Aug 10, 2022
Merged
@codecov
Copy link

codecov bot commented Aug 10, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@11d40a0). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11507   +/-   ##
===============================================
  Coverage                ?   86.48%           
===============================================
  Files                   ?      144           
  Lines                   ?    22850           
  Branches                ?        0           
===============================================
  Hits                    ?    19761           
  Misses                  ?     3089           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@galipremsagar galipremsagar added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Aug 10, 2022
@galipremsagar galipremsagar changed the title upgrade to arrow 9.0 [REVIEW] Upgrade to arrow-9.0 Aug 10, 2022
@galipremsagar galipremsagar changed the title [REVIEW] Upgrade to arrow-9.0 [REVIEW] Upgrade to arrow-9.x Aug 10, 2022
@galipremsagar galipremsagar marked this pull request as ready for review August 10, 2022 19:21
@galipremsagar galipremsagar requested review from a team as code owners August 10, 2022 19:21
galipremsagar
galipremsagar commented Aug 10, 2022
View reviewed changes
ci/cpu/build.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the gpuCI label Aug 10, 2022
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team gpuCI and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Aug 10, 2022
@github-actions github-actions bot removed the gpuCI label Aug 10, 2022
bdice
bdice approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving CMake.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 10, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9257549 into rapidsai:branch-22.10 Aug 10, 2022
@ttnghia ttnghia mentioned this pull request Aug 11, 2022
Merged
rapids-bot bot pushed a commit that referenced this pull request Aug 11, 2022
@ttnghia
Fix cmake error after upgrading to Arrow 9 (#11513)
de06ed9 
After upgrading to Arrow 9 (#11507), some systems experience a cmake issue:
```
cudf/cpp/build/_deps/arrow-src/cpp/CMakeLists.txt:864: error: The dependency target "xsimd" of target "arrow_dependencies" does not exist.
```

This may be due to the configurations for Arrow is looking for a local installation of `xsimd`, which does not exist or the installation path is not provided.

This PRs adds an option to cudf cmake, specifying that Arrow should handle `xsimd` by itself.

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #11513
@jlowe jlowe mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@bdice bdice bdice approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @bdice @ajschmidt8