Fix floating point data generation in benchmarks #10372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
tests
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10372 +/- ##
================================================
+ Coverage 10.42% 10.58% +0.15%
================================================
Files 119 125 +6
Lines 20603 21058 +455
================================================
+ Hits 2148 2228 +80
- Misses 18455 18830 +375
Continue to review full report at Codecov.
|
bdice
approved these changes
Mar 1, 2022
|
Tests appear to be failing with an unrelated error? #10150? |
…bug-data_gen-limits
…nto bug-data_gen-limits
I think it's a CI weirdness caused by API changes in #10150. Merged latest, that usually helps in such cases. |
nvdbaranec
approved these changes
Mar 7, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numeric_limits::lowestandnumeric_limits::maxare used as bounds for numeric type generation. However, for normal generators, bounds are shifted to[0, upper_bound - lower_bound], and the random value is shifted back bylower_bound.with
lowestandmax,upper_bound - lower_boundis out of range for floats and generated values arenanandinf.This PR halves the ranges so that
upper_bound - lower_boundis still within the type range.Expected to affect benchmarks that use floating point columns (e.g. Parquet reader benchmarks).