Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix floating point data generation in benchmarks (#10372)
`numeric_limits::lowest` and `numeric_limits::max` are used as bounds for numeric type generation. However, for normal generators, bounds are shifted to `[0, upper_bound - lower_bound]`, and the random value is shifted back by `lower_bound`. with `lowest` and `max`, `upper_bound - lower_bound` is out of range for floats and generated values are `nan` and `inf`. This PR halves the ranges so that `upper_bound - lower_bound` is still within the type range. Expected to affect benchmarks that use floating point columns (e.g. Parquet reader benchmarks). Authors: - Vukasin Milovanovic (https://github.com/vuule) Approvers: - Bradley Dice (https://github.com/bdice) - https://github.com/nvdbaranec URL: #10372
- Loading branch information