Merge branch 'bug-data_gen-limits' of https://github.com/vuule/cudf i…

…nto bug-data_gen-limits
rapidsai · Mar 2, 2022 · e20e5fa · e20e5fa
2 parents 7aa752d + 6af58ba
commit e20e5fa
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/cpp/benchmarks/common/generate_input.hpp b/cpp/benchmarks/common/generate_input.hpp
@@ -114,6 +114,7 @@ std::pair<int64_t, int64_t> default_range()
 template <typename T, std::enable_if_t<cudf::is_numeric<T>()>* = nullptr>
 std::pair<T, T> default_range()
 {
+  // Limits need to be such that `upper - lower` does not overflow
   return {std::numeric_limits<T>::lowest() / 2, std::numeric_limits<T>::max() / 2};
 }
 }  // namespace