Consolidate C++ conda recipes and add libcudf-tests package
#10326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
added
improvement
ajschmidt8
force-pushed
the
update-recipes
branch
5 times, most recently
from
6444f75 to
82d6c59
Compare
ajschmidt8
force-pushed
the
update-recipes
branch
4 times, most recently
from
c657f13 to
c7f29f8
Compare
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10326 +/- ##
===============================================
Coverage ? 86.34%
===============================================
Files ? 140
Lines ? 22294
Branches ? 0
===============================================
Hits ? 19249
Misses ? 3045
Partials ? 0 Continue to review full report at Codecov.
|
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Mar 17, 2022
This PR updates the `librmm` `conda` recipe with some learnings from rapidsai/cudf#10326. Namely that the top-level `build.sh` script is the only feasible approach for consolidating the recipes. The implication of these changes is that any shared libraries used in the top-level build must now manually be specified as `run` dependencies of the corresponding `outputs` package. To help reduce the amount of duplication of version specifications for these packages, dependency versions can be specified in `conda/recipes/librmm/conda_build_config.yaml`. The exception here is the version spec used for `cudatoolkit` since that comes from an environment variable in the CI process. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Jake Awe (https://github.com/AyodeAwe) - Jordan Jacobelli (https://github.com/Ethyling) URL: #997
Co-authored-by: Charles Blackmon-Luca <[email protected]>
jakirkham
approved these changes
Mar 19, 2022
ajschmidt8
added
non-breaking
ajschmidt8
force-pushed
the
update-recipes
branch
from
04094b4 to
7deedf6
Compare
ajschmidt8
changed the title
conda recipes and add libcudf_tests packageconda recipes and add libcudf-tests package
jlowe
approved these changes
Mar 29, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
The Build Metrics Report was accidentally disabled in #10326. This will add the flags back to the `build.sh` that are required to generate the report during CI. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #10562
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
libcudf-testspackage to thelibcudfrecipelibcudf-testspackage was added as an additional output to the existinglibcudfrecipe (which was renamed tolibcudf-split)libcudf-splitrecipeconda buildin our CI scriptsThe result of consolidating the C++ recipes into a single
libcudf-splitrecipe is that one top-level build occurs, which builds all of the C++ components (inconda/recipes/libcudf/build.sh) but does not install them. The installation for each package occurs in the correspondingconda/recipes/libcudf/install_libcudf.sh,conda/recipes/libcudf/install_libcudf_kafka.sh, etc. scripts.There are some implications to these changes. Namely that any top-level
hostrequirement which includes arun_exportsvalue (i.e. shared libraries) must now be manually specified in therundependencies of the correspondingoutputspackage. To help keep things DRY, dependency version specs can be specified inconda/recipes/librmm/conda_build_config.yaml. The exception here is the version spec used forcudatoolkitsince that comes from an environment variable in the CI process.