-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libcuml-tests package #4635
Conversation
1e9caf1
to
0e7977c
Compare
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #4635 +/- ##
===============================================
Coverage ? 83.85%
===============================================
Files ? 251
Lines ? 20282
Branches ? 0
===============================================
Hits ? 17007
Misses ? 3275
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
rerun tests |
rerun tests |
rerun tests |
Signed-off-by: Jordan Jacobelli <[email protected]>
nccl_version: | ||
- ">=2.9.9" | ||
|
||
treelite_version: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question for the future, the versions of this file would be also potentially used by the cuml
conda recipe, no? Particularly treelite
for example, is there a way to put this file in conda/recipes
so that it could be shared?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely. We can use the --variant-config-files
/-m
flag in the conda build
command to point to a particular file that has all of the version specifications. This is what's done in the integration
repo's versions.yaml
file. Here's the official conda
docs on that file for reference:
We can implement this as a future enhancement since we have some additional CI changes coming soon.
@gpucibot merge |
Add a `libcuml-tests` package to the `libcuml` recipe: - This is a prerequisite for removing "Project Flash" from our build/CI scripts. - The `libcuml-tests` package was added as an additional output to the existing `libcuml` recipe (which was renamed to `libcuml-split`) Authors: - Jordan Jacobelli (https://github.com/Ethyling) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4635
Add a `libcuml-tests` package to the `libcuml` recipe: - This is a prerequisite for removing "Project Flash" from our build/CI scripts. - The `libcuml-tests` package was added as an additional output to the existing `libcuml` recipe (which was renamed to `libcuml-split`) Authors: - Jordan Jacobelli (https://github.com/Ethyling) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4635
Add a
libcuml-tests
package to thelibcuml
recipe:libcuml-tests
package was added as an additional output to the existinglibcuml
recipe (which was renamed tolibcuml-split
)