Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libcuml-tests package #4635

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

jjacobelli
Copy link
Contributor

Add a libcuml-tests package to the libcuml recipe:

  • This is a prerequisite for removing "Project Flash" from our build/CI scripts.
  • The libcuml-tests package was added as an additional output to the existing libcuml recipe (which was renamed to libcuml-split)

@jjacobelli jjacobelli added 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 17, 2022
@jjacobelli jjacobelli self-assigned this Mar 17, 2022
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Mar 17, 2022
@jjacobelli jjacobelli force-pushed the consolidate branch 4 times, most recently from 1e9caf1 to 0e7977c Compare March 17, 2022 17:51
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@701b62f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.04    #4635   +/-   ##
===============================================
  Coverage                ?   83.85%           
===============================================
  Files                   ?      251           
  Lines                   ?    20282           
  Branches                ?        0           
===============================================
  Hits                    ?    17007           
  Misses                  ?     3275           
  Partials                ?        0           
Flag Coverage Δ
dask 44.93% <0.00%> (?)
non-dask 77.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 701b62f...0e7977c. Read the comment docs.

@jjacobelli
Copy link
Contributor Author

rerun tests

ci/gpu/build.sh Outdated Show resolved Hide resolved
conda/recipes/libcuml/meta.yaml Show resolved Hide resolved
ci/cpu/upload.sh Outdated Show resolved Hide resolved
@jjacobelli jjacobelli changed the base branch from branch-22.04 to branch-22.06 March 24, 2022 09:13
@ajschmidt8 ajschmidt8 removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 28, 2022
@ajschmidt8
Copy link
Member

rerun tests

@jjacobelli jjacobelli marked this pull request as ready for review March 29, 2022 17:55
@jjacobelli jjacobelli requested review from a team as code owners March 29, 2022 17:55
@jjacobelli
Copy link
Contributor Author

rerun tests

Signed-off-by: Jordan Jacobelli <[email protected]>
nccl_version:
- ">=2.9.9"

treelite_version:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question for the future, the versions of this file would be also potentially used by the cuml conda recipe, no? Particularly treelite for example, is there a way to put this file in conda/recipes so that it could be shared?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, absolutely. We can use the --variant-config-files/-m flag in the conda build command to point to a particular file that has all of the version specifications. This is what's done in the integration repo's versions.yaml file. Here's the official conda docs on that file for reference:

We can implement this as a future enhancement since we have some additional CI changes coming soon.

@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c4c80aa into rapidsai:branch-22.06 Apr 4, 2022
venkywonka pushed a commit to venkywonka/cuml that referenced this pull request Apr 26, 2022
Add a `libcuml-tests` package to the `libcuml` recipe:
- This is a prerequisite for removing "Project Flash" from our build/CI scripts.
- The `libcuml-tests` package was added as an additional output to the existing `libcuml` recipe (which was renamed to `libcuml-split`)

Authors:
  - Jordan Jacobelli (https://github.com/Ethyling)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4635
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Add a `libcuml-tests` package to the `libcuml` recipe:
- This is a prerequisite for removing "Project Flash" from our build/CI scripts.
- The `libcuml-tests` package was added as an additional output to the existing `libcuml` recipe (which was renamed to `libcuml-split`)

Authors:
  - Jordan Jacobelli (https://github.com/Ethyling)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants