-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libcuml-tests package #4635
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,10 @@ | ||
#!/bin/bash | ||
# Copyright (c) 2018-2022, NVIDIA CORPORATION. | ||
|
||
if [ -n "$MACOSX_DEPLOYMENT_TARGET" ]; then | ||
# C++11 requires 10.9 | ||
# but cudatoolkit 8 is build for 10.11 | ||
export MACOSX_DEPLOYMENT_TARGET=10.11 | ||
fi | ||
|
||
if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then | ||
./build.sh clean libcuml -v --allgpuarch | ||
else | ||
./build.sh clean libcuml prims -v --allgpuarch | ||
fi | ||
./build.sh -n clean libcuml prims -v --allgpuarch |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
cmake_version: | ||
- ">=3.20.1,<3.23" | ||
|
||
nccl_version: | ||
- ">=2.9.9" | ||
|
||
treelite_version: | ||
- "2.3.0" | ||
|
||
gtest_version: | ||
- "1.10.0" | ||
|
||
libfaiss_version: | ||
- "1.7.0" | ||
|
||
libcusolver_version: | ||
- ">=11.2.1" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/bash | ||
# Copyright (c) 2018-2022, NVIDIA CORPORATION. | ||
|
||
cmake --install cpp/build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/bash | ||
# Copyright (c) 2018-2022, NVIDIA CORPORATION. | ||
|
||
cmake --install cpp/build --component testing |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question for the future, the versions of this file would be also potentially used by the
cuml
conda recipe, no? Particularlytreelite
for example, is there a way to put this file inconda/recipes
so that it could be shared?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely. We can use the
--variant-config-files
/-m
flag in theconda build
command to point to a particular file that has all of the version specifications. This is what's done in theintegration
repo'sversions.yaml
file. Here's the officialconda
docs on that file for reference:We can implement this as a future enhancement since we have some additional CI changes coming soon.