Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Build Metrics Report #10562

Merged

Conversation

davidwendt
Copy link
Contributor

The Build Metrics Report was accidentally disabled in #10326. This will add the flags back to the build.sh that are required to generate the report during CI.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Mar 31, 2022
@davidwendt davidwendt self-assigned this Mar 31, 2022
@davidwendt davidwendt requested a review from a team as a code owner March 31, 2022 20:55
@github-actions github-actions bot added conda and removed libcudf Affects libcudf (C++/CUDA) code. labels Mar 31, 2022
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Sorry @davidwendt!

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #10562 (96dfe2b) into branch-22.06 (73bc7d7) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.06   #10562   +/-   ##
=============================================
  Coverage         86.33%   86.33%           
=============================================
  Files               140      140           
  Lines             22300    22300           
=============================================
  Hits              19253    19253           
  Misses             3047     3047           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4775f11...96dfe2b. Read the comment docs.

@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d50d1ef into rapidsai:branch-22.06 Mar 31, 2022
@davidwendt davidwendt deleted the bug-renable-build-metrics branch April 1, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants