fix gcc 11 compilation errors #10067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongou
added
bug
vuule
reviewed
Jan 18, 2022
| @@ -171,7 +171,7 @@ std::vector<metadata::stripe_source_mapping> aggregate_orc_metadata::select_stri | |||
|
|
|||
| // Coalesce stripe info at the source file later since that makes downstream processing much | |||
| // easier in impl::read | |||
| for (const size_t& stripe_idx : user_specified_stripes[src_file_idx]) { | |||
| for (const size_t stripe_idx : user_specified_stripes[src_file_idx]) { | |||
There was a problem hiding this comment.
#10045 already addresses this one.
jlowe
reviewed
Jan 18, 2022
davidwendt
reviewed
Jan 18, 2022
| @@ -18,6 +18,8 @@ | |||
| #include <cudf/scalar/scalar.hpp> | |||
| #include <cudf/strings/strings_column_view.hpp> | |||
|
|
|||
| #include <optional> | |||
There was a problem hiding this comment.
The <optional> include is being addressed in #10044
| @@ -31,6 +31,7 @@ | |||
|
|
|||
| #include <future> | |||
| #include <memory> | |||
| #include <optional> | |||
There was a problem hiding this comment.
Thanks for finding this benchmark issue, I have updated #10044 to address this as well.
jlowe
approved these changes
Jan 18, 2022
vuule
added
5 - Ready to Merge
|
rerun tests |
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #10067 +/- ##
================================================
- Coverage 10.49% 10.41% -0.08%
================================================
Files 119 119
Lines 20305 20541 +236
================================================
+ Hits 2130 2139 +9
- Misses 18175 18402 +227
Continue to review full report at Codecov.
|
ttnghia
approved these changes
Jan 19, 2022
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gcc 11 compilation errors.