-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix gcc 11 compilation errors #10067
Changes from 1 commit
ea50f22
d68e7f5
dca6fad
691b648
2c49f17
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,8 @@ | |
#include <cudf/scalar/scalar.hpp> | ||
#include <cudf/strings/strings_column_view.hpp> | ||
|
||
#include <optional> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reverted. |
||
|
||
namespace cudf { | ||
namespace strings { | ||
/** | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -171,7 +171,7 @@ std::vector<metadata::stripe_source_mapping> aggregate_orc_metadata::select_stri | |
|
||
// Coalesce stripe info at the source file later since that makes downstream processing much | ||
// easier in impl::read | ||
for (const size_t& stripe_idx : user_specified_stripes[src_file_idx]) { | ||
for (const size_t stripe_idx : user_specified_stripes[src_file_idx]) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #10045 already addresses this one. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reverted. |
||
CUDF_EXPECTS(stripe_idx < per_file_metadata[src_file_idx].ff.stripes.size(), | ||
"Invalid stripe index"); | ||
stripe_infos.push_back( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this benchmark issue, I have updated #10044 to address this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted.