-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix columns
ordering issue in parquet reader
#10066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small suggestion, rest looks good
rerun tests |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #10066 +/- ##
================================================
- Coverage 10.49% 10.41% -0.08%
================================================
Files 119 119
Lines 20305 20541 +236
================================================
+ Hits 2130 2139 +9
- Misses 18175 18402 +227
Continue to review full report at Codecov.
|
rerun tests |
1 similar comment
rerun tests |
|
This was a cupy flaky issue, #10071 has a fix for it. I'll get it merged ASAP. |
@gpucibot merge |
Fixes: #10062
This PR fixes issue where the order of
columns
and parquet metadata columns(i.e.,meta['columns']
) can differ and both are not guaranteed to be in the same order always. In this PR, removed the code that has this assumption and created a new dict that contains the metadata of columns which are later used to update the column metadata in dataframe.