Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update to mypy >= v1 #13336

Closed
wence- opened this issue May 11, 2023 · 0 comments · Fixed by #13340
Closed

[FEA] Update to mypy >= v1 #13336

wence- opened this issue May 11, 2023 · 0 comments · Fixed by #13340
Assignees
@wence-
Labels
feature request New feature or request improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Milestone
cuDF Python Refac...

Comments

@wence-
Copy link
Contributor

wence- commented May 11, 2023

Mypy v1 is out, which (amongst other things) introduces support for PEP 673 "The Self type". Being able to use this will make typing a lot of our factory class methods simpler.
@wence- wence- added feature request New feature or request code quality Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function labels May 11, 2023
@wence- wence- self-assigned this May 11, 2023
@wence- wence- added this to the cuDF Python Refactoring milestone May 11, 2023
@vyasr vyasr mentioned this issue May 11, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue May 12, 2023
@wence-
Update mypy to 1.3 (#13340)
6c4ff21 
Bring us up to date with the current mypy release. Big diff, mostly due to the no-implicit-optional rule that mypy now enforces (see commit message of 040f577 for details). That commit is automated so probably best to review commit-by-commit for the substantive changes.

- Closes #13336

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #13340
@wence- wence- mentioned this issue May 12, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue May 15, 2023
@wence-
Expunge most uses of TypeVar(bound="Foo") (#13346)
40e4fbe 
With #13336, we can use the PEP674 `Self` type.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #13346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wence- wence-

Labels
feature request New feature or request improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Milestone
cuDF Python Refactoring
Development

Successfully merging a pull request may close this issue.

Update mypy to 1.3 wence-/cudf
1 participant
@wence-