Update mypy to 1.3 #13340
Merged
Update mypy to 1.3 #13340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP484 prohibits implicit Optional types, so
def bad(x: int = None):
pass
Is invalid. MyPy since version 0.983 prohibits this usage by default.
So rewrite all of the typing (except x : Any = None) using
https://github.com/hauntsaninja/no_implicit_optional.
Since the body has type information, the return type needs to be annotated otherwise mypy produces a warning.
wence-
added
improvement
|
This closes issue #13336, right? |
Yes, which I had somehow forgotten I had written as I was making this branch |
vyasr
approved these changes
May 11, 2023
|
/merge |
|
@wence- Huge thanks for this. This update will make it easier to keep other pre-commit hooks updated on a semi-regular basis with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bring us up to date with the current mypy release. Big diff, mostly due to the no-implicit-optional rule that mypy now enforces (see commit message of 040f577 for details). That commit is automated so probably best to review commit-by-commit for the substantive changes.
Checklist