Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expunge most uses of TypeVar(bound="Foo") #13346

Merged
merged 3 commits into from
May 15, 2023
Merged

Expunge most uses of TypeVar(bound="Foo") #13346

merged 3 commits into from
May 15, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented May 12, 2023

Description

With #13336, we can use the PEP674 Self type.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

wence- added 3 commits May 12, 2023 13:00
@wence- wence- requested a review from a team as a code owner May 12, 2023 16:21
@wence- wence- requested review from bdice and galipremsagar May 12, 2023 16:21
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 12, 2023
@wence- wence- mentioned this pull request May 12, 2023
Merged
3 tasks
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 12, 2023
@wence-
Copy link
Contributor Author

wence- commented May 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit 40e4fbe into rapidsai:branch-23.06 May 15, 2023
@wence- wence- deleted the wence/fea/moar-typing branch May 15, 2023 08:31
@wence- wence- mentioned this pull request May 17, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wence- @bdice