Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: move unit tests for epics into integration #2639

Conversation

weilbith
Copy link
Contributor

Due to complex conflict issue in #2635 we have reset master to disregard the changes of #2636 This is now the same thing again but includes the changes made by #2635 As nothing has changed to the original PR (in terms of what has been done) this does not need another review and I'll handle this PR completely on my own. The only purpose of having a PR is to trigger the CI pipeline.

The current unit tests for the epics are no real unit tests. They
combine many units of the SDK together and check their functionality as
an association. Therefore they belong better to the integration test
suite.
@codecov

This comment has been minimized.

@weilbith weilbith merged commit 79cb6d2 into raiden-network:master Mar 26, 2021
@weilbith weilbith deleted the feature/sdk-move-epic-unit-tests-to-integration-tests branch March 26, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant