Interactive UDC withdraw #2635
Merged
Interactive UDC withdraw #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2635 +/- ##
==========================================
- Coverage 89.84% 89.68% -0.17%
==========================================
Files 172 175 +3
Lines 7004 7089 +85
Branches 1177 1185 +8
==========================================
+ Hits 6293 6358 +65
- Misses 623 643 +20
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
andrevmatos
force-pushed
the
feature/split_udc_withdraw
branch
from
290ab82
to
a4fae97
Compare
|
You modified |
...into pathfinding, monitor and udc epics, since the generic epic module was already too big.
Now named udcWithdraw, and the previous udcWithdraw is renamed to udcWithdrawPlan. Also, a small refactoring to check if totalDeposit is outdated late, right before calling deposit (after approveIfNeeded$).
andrevmatos
force-pushed
the
feature/split_udc_withdraw
branch
from
a4fae97
to
4e81cd6
Compare
udcWithdraw phase (after plan) is now a request/success/failure epic. udcWithdraw.request is handled, dispatches the transaction, wait for it to be mined and output either success or failure. If config.autoUdcWithdraw is enabled (default), an epic will watch the blockchain for plans from us and dispatch the udcWithdraw.request
The former queries the UDC for currently planned withdraws, returning amount, block in which it becomes available and ready state; the later is to be called when config.autoUdcWithdraw is false and after plan is 'ready', and interactively performs the last UDC withdraw phase.
andrevmatos
force-pushed
the
feature/split_udc_withdraw
branch
from
4e81cd6
to
63280a5
Compare
palango
reviewed
Mar 25, 2021
weilbith
suggested changes
Mar 25, 2021
There was a problem hiding this comment.
Thanks for taking the time and implementing this feature. What sound to easy in the beginning actually became quite big.
I'm pretty happy with most of it. Just the epic to auto-trigger withdrawals is not so nice as I think. We should discuss it together. Especially the hard binding to the exact contract deployment constructor value is not so nice. I would like to get rid of it.
weilbith
approved these changes
Mar 25, 2021
- Raiden.udcWithdraw -> Raiden.withdrawFromUDC - Raiden.planUdcWithdraw -> Raiden.planUDCWithdraw - config.autoUdcWithdraw -> config.autoUDCWithdraw - 100 -> constants.UDC_WITHDRAW_TIMEOUT
This was referenced Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2629
Short description
Refactor: split services/epics into separate modules for UDC handling, MS and PFS.
udcWithdrawis split into 2 sets of independent async actions:udc/withdraw/plan, which is responsible only for the planning transaction, per user request, and triggered fromRaiden.planUdcWithdrawpublic method, andudc/withdraw, which triggers the final step, after 100 blocks of the planned tx, which got exposed throughRaiden.udcWithdrawmethod.Additionally, the current plan (if any) can be checked from the new
Raiden.getUdcWithdrawPlanmethod, which will resolve toundefinedif there's none, or to an object containingamount,block(block at which it'll become ready) andready(boolean to tell if it's already ready).A new
config.autoUdcWithdraw, which defaults to true, enables an epic which will watch the blockchain and automaticallyudc/withdraw/requestwhen a plan is ready; it can be turned off, and only thenRaiden.udcWithdrawis made available for the interactive 2nd step udcWithdraw.Definition of Done
Steps to manually test the change (dApp)