Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: move unit tests for epics into integration #2636

Conversation

weilbith
Copy link
Contributor

Fixes #2585

Short description
This is basically just about the moving part. Will be followed up by #2583

The current unit tests for the epics are no real unit tests. They
combine many units of the SDK together and check their functionality as
an association. Therefore they belong better to the integration test
suite.
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #2636 (30a5f0a) into master (0a7f39d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2636   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files         172      172           
  Lines        7004     7004           
  Branches     1177     1177           
=======================================
  Hits         6293     6293           
  Misses        623      623           
  Partials       88       88           
Flag Coverage Δ
dapp 87.49% <ø> (ø)
dapp.unit 87.49% <ø> (ø)
sdk 90.96% <ø> (ø)
sdk.e2e 59.76% <ø> (ø)
sdk.integration 81.01% <ø> (+80.74%) ⬆️
sdk.unit 34.34% <ø> (-50.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7f39d...30a5f0a. Read the comment docs.

@weilbith weilbith requested a review from palango March 25, 2021 14:08
@weilbith weilbith merged commit d000337 into raiden-network:master Mar 25, 2021
@weilbith weilbith deleted the feature/sdk-move-epic-unit-tests-to-integration-tests branch March 25, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move some epics from unit tests to integration tests
2 participants