Make channelClose & channelSettle success actions confirmable #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
+ Coverage 96.02% 96.03% +0.01%
==========================================
Files 96 96
Lines 3644 3658 +14
Branches 781 784 +3
==========================================
+ Hits 3499 3513 +14
Misses 88 88
Partials 57 57
Continue to review full report at Codecov.
|
kelsos
reviewed
Feb 13, 2020
kelsos
reviewed
Feb 13, 2020
kelsos
approved these changes
Feb 13, 2020
andrevmatos
force-pushed
the
feat/confirmation3
branch
from
2bd7512
to
01ec65c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #613
After #1009 & #1013
Notice unconfirmed
ChannelClose&Settlealready puts the channels on statesclosing&settling, respectively. The former is important mainly because now we can stop accepting transfers on a channel on first sight of partner closing it, even before confirmation, which puts channel effectively in theclosedstate and allows for settling aftersettleTimeout.