Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make channelDeposit & channelWithdrawn confirmable actions #1013

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

andrevmatos
Copy link
Contributor

On top of #1009
Part of #613

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #1013 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1013   +/-   ##
=======================================
  Coverage   96.00%   96.01%           
=======================================
  Files          95       95           
  Lines        3633     3636    +3     
  Branches      746      749    +3     
=======================================
+ Hits         3488     3491    +3     
  Misses         88       88           
  Partials       57       57           
Flag Coverage Δ
#dapp 91.46% <ø> (ø) ⬆️
#sdk 97.86% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be4b06...6521de8. Read the comment docs.

Copy link
Contributor

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you 👍

@andrevmatos andrevmatos merged commit 8883c6e into master Feb 12, 2020
@andrevmatos andrevmatos deleted the feat/confirmation2 branch February 12, 2020 14:05
@andrevmatos andrevmatos linked an issue Feb 12, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement confirmation blocks
3 participants