-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement confirmation blocks #613
Labels
Comments
andrevmatos
added
enhancement
New feature or request
sdk 🖥
backlog
Proposals or issues to be fixed in the future
labels
Nov 27, 2019
@andrevmatos to describe the design / architecture / tasks |
3 tasks
This was
linked to
pull requests
Feb 12, 2020
andrevmatos
added a commit
that referenced
this issue
Feb 13, 2020
andrevmatos
added a commit
that referenced
this issue
Feb 13, 2020
andrevmatos
added a commit
that referenced
this issue
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently, our blockchain interface through
ethers
treats any event as final, which could not be true if a reorg occurs. Raiden also don't see an event as confirmed before a given number of blocks (currently, default of 5).Fortunately, our Rx/redux architecture provides a strong ground to support it in a selective manner, as some events may require confirmation and some don't.
This can use #591 between pending and confirmation events actions. Could also make use of #357 to update users about confirmation progress.
TODO: expand implementation description
Acceptance criteria
Tasks
The text was updated successfully, but these errors were encountered: