Refactoring of exceptions #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OPersian please also review |
z4y4ts
suggested changes
Feb 9, 2017
video_xblock/backends/base.py
Outdated
| @@ -307,8 +303,8 @@ def get_transcript_language_parameters(lang_code): | |||
| lang_code = lang_code[0:2] | |||
| # Check on consistency with the pre-configured ALL_LANGUAGES | |||
| if lang_code not in [language[0] for language in settings.ALL_LANGUAGES]: | |||
| raise Exception('Not all the languages of transcripts fetched from video platform are ' | |||
| 'consistent with the pre-configured ALL_LANGUAGES') | |||
| raise VideoXBlockException(_('Not all the languages of transcripts fetched from video platform are ' | |||
There was a problem hiding this comment.
Please follow Open edX JavaScript code style guide.
video_xblock/exceptions.py
Outdated
| Base class for video xblock exceptions. | ||
| Subclasses should provide `.default_detail` property. | ||
| """ | ||
| default_detail = _('An exception occurred.') |
There was a problem hiding this comment.
default_msg and msg (or message) feels more appropriate here.
dorosh
approved these changes
Feb 9, 2017
video_xblock/exceptions.py
Outdated
| """ | ||
| Base API client exception. | ||
| """ | ||
| default_detail = _('API error occurred.') |
There was a problem hiding this comment.
@dorosh it's there. Otherwise, GitHub would show something like ↵∅
z4y4ts
approved these changes
Feb 9, 2017
|
@z4y4ts please continue review |
|
Squash and merge. |
z4y4ts
added a commit
that referenced
this pull request
Feb 9, 2017
* dev: Add markdownlint to .codeclimate.yml and fix minor README.md issues (#105) Tweak .travis.yml for faster build times and bump XBlock dependency (#113) Refactoring of exceptions (#114) added statuses constants (#111) Add comments into .editorconfig with a link to download page Add Default transcripts upload and Brightcove HLSe (#104) Bug/settings page studio (#103) Fix saving playback progress by correctly reading it from localStorage (#102) Move bower.json to root directory, add .bowerrc, add make deps target (#101) # Conflicts: # .travis.yml # Makefile # requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a good idea to have base video xblock exceptions to distinguish them from other bad code.
@z4y4ts @dorosh please review