forked from appsembler/xblock-video
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/settings page studio #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add into options "tabindex" to togleButton - add into options "tabIndex" to transcript
z4y4ts
approved these changes
Feb 6, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Remove pylint thing and it's good to go.
Please remember to squash.
video_xblock/backends/vimeo.py
Outdated
@@ -92,10 +92,11 @@ def download_default_transcript(self, url): # pylint: disable=unused-argument | |||
def customize_xblock_fields_display(editable_fields): # pylint: disable=unused-argument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can now remove pylint muting
-fill method customize_xblock_fields_display for return video fields
496de26
to
e0077db
Compare
z4y4ts
added a commit
that referenced
this pull request
Feb 6, 2017
…codeclimate * commit 'd9343737e8092535da4fdc3cbdaaf3690080d090': Bug/settings page studio (#103)
z4y4ts
added a commit
that referenced
this pull request
Feb 9, 2017
* dev: Add markdownlint to .codeclimate.yml and fix minor README.md issues (#105) Tweak .travis.yml for faster build times and bump XBlock dependency (#113) Refactoring of exceptions (#114) added statuses constants (#111) Add comments into .editorconfig with a link to download page Add Default transcripts upload and Brightcove HLSe (#104) Bug/settings page studio (#103) Fix saving playback progress by correctly reading it from localStorage (#102) Move bower.json to root directory, add .bowerrc, add make deps target (#101) # Conflicts: # .travis.yml # Makefile # requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.