Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdownlint to .codeclimate.yml and fix minor README.md issues #105

Merged
merged 11 commits into from
Feb 9, 2017

Conversation

z4y4ts
Copy link

@z4y4ts z4y4ts commented Feb 6, 2017

No description provided.

* dev:
  Fix saving playback progress by correctly reading it from localStorage (#102)
  Move bower.json to root directory, add .bowerrc, add make deps target (#101)
  Run pep8 before pylint and keep make quality running even if they fail
  Reduce target python versions to latest and the one used by Eucalyptus
  Feature/vimeo (#98)

# Conflicts:
#	README.md
…codeclimate

* commit 'd9343737e8092535da4fdc3cbdaaf3690080d090':
  Bug/settings page studio (#103)
@z4y4ts z4y4ts self-assigned this Feb 6, 2017
@z4y4ts z4y4ts requested review from dorosh and TamoshaytisV February 7, 2017 22:38
@z4y4ts z4y4ts requested a review from OPersian February 9, 2017 10:28
Copy link

@OPersian OPersian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.travis.yml Outdated

addons:
code_climate:
repo_token: 8b6b72db7cca0082ac23c0d86062b40eb3761d65bdfaafa85c491a2e0b95f8bd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it safe to store token in public repository?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This token is ok to expose to the public.
But I'm actually gonna remove this thing since it's needed for coverage reporting to CodeClimate, which is not going to happen now.

@z4y4ts z4y4ts merged commit 4a40cc4 into dev Feb 9, 2017
@z4y4ts z4y4ts deleted the quality/codeclimate branch February 9, 2017 12:19
z4y4ts added a commit that referenced this pull request Feb 9, 2017
* dev:
  Add markdownlint to .codeclimate.yml and fix minor README.md issues (#105)
  Tweak .travis.yml for faster build times and bump XBlock dependency (#113)
  Refactoring of exceptions (#114)
  added statuses constants (#111)
  Add comments into .editorconfig with a link to download page
  Add Default transcripts upload and Brightcove HLSe (#104)
  Bug/settings page studio (#103)
  Fix saving playback progress by correctly reading it from localStorage (#102)
  Move bower.json to root directory, add .bowerrc, add make deps target (#101)

# Conflicts:
#	.travis.yml
#	Makefile
#	requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants