Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sf 0.9 submission to CRAN #1310

Closed
edzer opened this issue Mar 20, 2020 · 5 comments
Closed

sf 0.9 submission to CRAN #1310

edzer opened this issue Mar 20, 2020 · 5 comments

Comments

@edzer
Copy link
Member

edzer commented Mar 20, 2020

See here for revdep checks. I went through all of them, and will resubmit a version that addresses point 2.

  1. Warning: replacing previous import ‘sf::st_make_valid’ by ‘lwgeom::st_make_valid’ when loading ‘bdl’

    st_make_valid is being moved from lwgeom to sf; packages importing
    both will now generate this warning on startup. This will go away
    automatically when I can submit lwgeom after sf, with lwgeom no
    longer exporting this method.

    Packages affected: bdl, EmissV, RGISTools, tmap

  2. problems now solved in sf;

    • st_sample has become a generic, but didn't export a sfg method
    • st_make_valid strips crs

    Packages affected: cartography, dssd, eSDM, GADMTools, transformr

  3. have been informed:

  1. False positives:
  • cdcfluview: curl error, happens at random places, also with current CRAN version of sf;
  • gtfs2gps: network error
  • NLMR: caused by fasterize, reported there
  • rasterDT: caused by fasterize, reported there
  • reproducible: caused by fasterize, reported there
@edzer
Copy link
Member Author

edzer commented Mar 22, 2020

@edzer
Copy link
Member Author

edzer commented Mar 22, 2020

(As expected: cartography, dssd, eSDM, GADMTools, transformr are now resolved)

@rafapereirabr
Copy link

Hi @edzer . Do you have a planed date to submit the new version of sf to CRAN?

@edzer
Copy link
Member Author

edzer commented Mar 24, 2020

Yes, it is in the submission process, and could appear any time soon now.

@edzer
Copy link
Member Author

edzer commented Mar 24, 2020

Third submission: on PROJ 7.0.0 tests would fail; 5187565 removes the unload_gdal() / load_gdal() test; potential issue raised here: OSGeo/gdal#2344

@edzer edzer closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants