Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming sf breaks nhdR on CRAN #62

Closed
edzer opened this issue Mar 20, 2020 · 1 comment
Closed

upcoming sf breaks nhdR on CRAN #62

edzer opened this issue Mar 20, 2020 · 1 comment

Comments

@edzer
Copy link

edzer commented Mar 20, 2020

See

Your tests don't pass with the new crs logic in upcoming sf. You could for instance use

expect_true(st_crs(toUTM(big_combined)) == st_crs(toUTM(sunapee$sp$NHDWaterbody)))

as an alternative: these crs are (now) semantically equal, but different in their represenation. Pls modify and submit to CRAN.
@edzer edzer mentioned this issue Mar 20, 2020
Closed
@jsta jsta closed this as completed in 3b63645 Mar 23, 2020
@jsta
Copy link
Owner

jsta commented Mar 23, 2020

Changed to use the suggested logic. FWIW I updated my sf to the 0.9 but didn't raise any errors with the old test logic...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edzer @jsta