Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming sf breaks rmapshaper on CRAN #103

Closed
edzer opened this issue Mar 20, 2020 · 7 comments
Closed

upcoming sf breaks rmapshaper on CRAN #103

edzer opened this issue Mar 20, 2020 · 7 comments

Comments

@edzer
Copy link

edzer commented Mar 20, 2020

See

Please update and submit to CRAN; let me know if you need help.

@ateucher
Copy link
Owner

Ok, thanks. Will look ASAP

Sent with GitHawk

@ateucher
Copy link
Owner

Well, after a single commit to fix the issue, and at least a day getting github actions working to actually check it with various GDAL/PROJ versions on all platforms, I think rmapshaper is good to go. Would you recommend waiting until sf is updated on CRAN or going now?

@edzer
Copy link
Author

edzer commented Mar 24, 2020

Yes.

@etiennebr may want to check out Andy's github actions work.

@ateucher
Copy link
Owner

Sorry, was that "Yes" to waiting for sf?

@edzer
Copy link
Author

edzer commented Mar 24, 2020

eh, yes. On second thought: no need to wait.

@ateucher
Copy link
Owner

Perfect, thanks!

@ateucher
Copy link
Owner

ateucher commented Apr 1, 2020

rmapshaper 0.4.4 on CRAN now, passing all checks so far: https://cran.r-project.org/web/checks/check_results_rmapshaper.html

@ateucher ateucher closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants