Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve toolbar #2993

Closed
ahmedre opened this issue Dec 3, 2024 · 0 comments
Closed

Improve toolbar #2993

ahmedre opened this issue Dec 3, 2024 · 0 comments

Comments

@ahmedre
Copy link
Contributor

ahmedre commented Dec 3, 2024

today, the RelativeLayout forces LTR - without this, the toolbar doesn't render properly. we should fix this properly. See #2992 for how removing this broke things and returning it to fix things for now.

some ayah markers are not ideal in the new page types on some ayat - for example, Sura 'Ankaboot ayah 1 - the pip appears in the middle of the portion of ayah 2 instead of on ayah 1.

note that:

  • this only happens with the line by line pages, not on the other page types
  • it happens irrespective of Arabic versus English
  • it was there in the older version released in January as well

relates to #2985.
ahmedre added a commit that referenced this issue Dec 7, 2024
@ahmedre
Fix many more toolbar issues
9ce9240 
After the last PR to fix some RTL toolbar issues, there were other
issues that were missed. For example, in landscape RTL, the toolbar was
broken. Moreover, it was broken for translations. This patch ensures
that the toolbar is well behaved in RTL and LTR in portrait and
landscape and in translation mode and normal mode (including on tablet
with dual screen and split screen modes).

The remaining issues not addressed by this PR are:

1. in landscape, when the toolbar is visible in translation mode and a
long press happens on an ayah, the y value is incorrectly lower than
the ayah box.

2. in tablet split screen mode, long pressing a translation and then
scrolling the translation down does not move the toolbar down.

Refs #2993.
@ahmedre ahmedre mentioned this issue Dec 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 7, 2024
@ahmedre
Fix many more toolbar issues
2e7e899 
After the last PR to fix some RTL toolbar issues, there were other
issues that were missed. For example, in landscape RTL, the toolbar was
broken. Moreover, it was broken for translations. This patch ensures
that the toolbar is well behaved in RTL and LTR in portrait and
landscape and in translation mode and normal mode (including on tablet
with dual screen and split screen modes).

The remaining issues not addressed by this PR are:

1. in landscape, when the toolbar is visible in translation mode and a
long press happens on an ayah, the y value is incorrectly lower than
the ayah box.

2. in tablet split screen mode, long pressing a translation and then
scrolling the translation down does not move the toolbar down.

Refs #2993.
ahmedre added a commit that referenced this issue Dec 8, 2024
@ahmedre
Fix the toolbar y position in landscape
1784c2a 
This fixes an issue where, in landscape translation mode, if the toolbar
is visible when a long press occurs, the y would be incorrect. Also make
the root a FrameLayout instead of a RelativeLayout.

Refs #2993.
@ahmedre ahmedre mentioned this issue Dec 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 8, 2024
@ahmedre
Fix the toolbar y position in landscape
9d07a11 
This fixes an issue where, in landscape translation mode, if the toolbar
is visible when a long press occurs, the y would be incorrect. Also make
the root a FrameLayout instead of a RelativeLayout.

Refs #2993.
@ahmedre ahmedre closed this as completed Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahmedre