Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix many more toolbar issues #3005

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Fix many more toolbar issues #3005

merged 1 commit into from
Dec 7, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 7, 2024

After the last PR to fix some RTL toolbar issues, there were other
issues that were missed. For example, in landscape RTL, the toolbar was
broken. Moreover, it was broken for translations. This patch ensures
that the toolbar is well behaved in RTL and LTR in portrait and
landscape and in translation mode and normal mode (including on tablet
with dual screen and split screen modes).

The remaining issues not addressed by this PR are:

  1. in landscape, when the toolbar is visible in translation mode and a
    long press happens on an ayah, the y value is incorrectly lower than
    the ayah box.

  2. in tablet split screen mode, long pressing a translation and then
    scrolling the translation down does not move the toolbar down.

Refs #2993.

After the last PR to fix some RTL toolbar issues, there were other
issues that were missed. For example, in landscape RTL, the toolbar was
broken. Moreover, it was broken for translations. This patch ensures
that the toolbar is well behaved in RTL and LTR in portrait and
landscape and in translation mode and normal mode (including on tablet
with dual screen and split screen modes).

The remaining issues not addressed by this PR are:

1. in landscape, when the toolbar is visible in translation mode and a
long press happens on an ayah, the y value is incorrectly lower than
the ayah box.

2. in tablet split screen mode, long pressing a translation and then
scrolling the translation down does not move the toolbar down.

Refs #2993.
Copy link

github-actions bot commented Dec 7, 2024

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │  24.1 MiB │  24.1 MiB │ +695 B │  74.7 MiB │  74.7 MiB │ +1.6 KiB 
     arsc │   2.7 MiB │   2.7 MiB │    0 B │   2.7 MiB │   2.7 MiB │      0 B 
 manifest │   5.8 KiB │   5.8 KiB │    0 B │    28 KiB │    28 KiB │      0 B 
      res │   1.7 MiB │   1.7 MiB │   -6 B │     2 MiB │     2 MiB │      0 B 
   native │  18.8 KiB │  18.8 KiB │    0 B │  36.5 KiB │  36.5 KiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │    0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 218.4 KiB │ 218.4 KiB │   +2 B │ 464.6 KiB │ 464.6 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  29.2 MiB │  29.2 MiB │ +691 B │  80.6 MiB │  80.6 MiB │ +1.6 KiB 

@ahmedre ahmedre added this pull request to the merge queue Dec 7, 2024
Merged via the queue into main with commit 2e7e899 Dec 7, 2024
2 checks passed
@ahmedre ahmedre deleted the fix_more_toolbar_issues branch December 7, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant