Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the toolbar y position in landscape #3006

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 8, 2024

This fixes an issue where, in landscape translation mode, if the toolbar
is visible when a long press occurs, the y would be incorrect. Also make
the root a FrameLayout instead of a RelativeLayout.

Refs #2993.

This fixes an issue where, in landscape translation mode, if the toolbar
is visible when a long press occurs, the y would be incorrect. Also make
the root a FrameLayout instead of a RelativeLayout.

Refs #2993.
Copy link

github-actions bot commented Dec 8, 2024

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │  24.1 MiB │  24.1 MiB │ +798 B │  74.7 MiB │  74.7 MiB │ +1.4 KiB 
     arsc │   2.7 MiB │   2.7 MiB │    0 B │   2.7 MiB │   2.7 MiB │      0 B 
 manifest │   5.8 KiB │   5.8 KiB │    0 B │    28 KiB │    28 KiB │      0 B 
      res │   1.7 MiB │   1.7 MiB │  -16 B │     2 MiB │     2 MiB │    -28 B 
   native │  18.8 KiB │  18.8 KiB │    0 B │  36.5 KiB │  36.5 KiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │    0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 218.4 KiB │ 218.4 KiB │  -19 B │ 464.6 KiB │ 464.6 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  29.2 MiB │  29.2 MiB │ +763 B │  80.6 MiB │  80.6 MiB │ +1.4 KiB 

@ahmedre ahmedre added this pull request to the merge queue Dec 8, 2024
Merged via the queue into main with commit 9d07a11 Dec 8, 2024
2 checks passed
@ahmedre ahmedre deleted the fix_y_in_translation branch December 8, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant