Suspense wrapper for ResourceCache #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3408 +/- ##
==========================================
- Coverage 35.78% 35.78% -0.01%
==========================================
Files 680 680
Lines 29691 29693 +2
Branches 4377 4377
==========================================
Hits 10626 10626
- Misses 17902 17904 +2
Partials 1163 1163
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nl0
approved these changes
Apr 11, 2023
nl0
requested changes
Apr 11, 2023
nl0
added a commit
that referenced
this pull request
Apr 25, 2023
* master: (24 commits) Rename hash to hashOrTag because tag is also acceptable (#3430) Type for `theme.typography.monospace` (#3428) Fix thumbnail lambda CI fail (#3433) Add link from side navigation and update text (#3431) Add "unreleased" section, fix entry (#3429) Fix file URL for embed (#3419) Add snapshot test for BucketIcon (#3422) doc: fix push args line breaks (#3424) Fix thumbnail lambda CI job (#3426) Breadcrumbs refactoring (#3417) Switch debug-harness from token to code (#3418) pkgselect: Ensure path ends with slash (#3411) Suspense wrapper for ResourceCache (#3408) Make gendocs bash scripts fail loudly (#3414) Bump debian in /s3-proxy (#3415) Bump debian in /lambdas/thumbnail (#3416) Quilt3 v5.3.0 (#3413) Hotfix: status reports bucket exception (#3412) Add --no-copy parameter to Package.push() (#3398) Pin anndata to fix tests on Windows (#3410) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useVoilausesResourceCache.useData(..., ..., { suspnese: true }), so it's required to wrap it with<Suspense />