Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file URL for embed #3419

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Fix file URL for embed #3419

merged 4 commits into from
Apr 19, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Apr 13, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #3419 (236c9ad) into master (7eb09d4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #3419   +/-   ##
=======================================
  Coverage   36.00%   36.00%           
=======================================
  Files         679      679           
  Lines       29699    29699           
  Branches     4387     4388    +1     
=======================================
  Hits        10694    10694           
+ Misses      17845    17844    -1     
- Partials     1160     1161    +1     
Flag Coverage Δ
api-python 91.23% <ø> (ø)
catalog 9.91% <0.00%> (ø)
lambda 86.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/constants/embed-routes.js 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 April 13, 2023 17:07
@fiskus fiskus merged commit d147444 into master Apr 19, 2023
@fiskus fiskus deleted the embed-bucket-file-url branch April 19, 2023 09:39
nl0 added a commit that referenced this pull request Apr 25, 2023
* master: (24 commits)
  Rename hash to hashOrTag because tag is also acceptable (#3430)
  Type for `theme.typography.monospace` (#3428)
  Fix thumbnail lambda CI fail (#3433)
  Add link from side navigation and update text (#3431)
  Add "unreleased" section, fix entry (#3429)
  Fix file URL for embed (#3419)
  Add snapshot test for BucketIcon (#3422)
  doc: fix push args line breaks (#3424)
  Fix thumbnail lambda CI job (#3426)
  Breadcrumbs refactoring (#3417)
  Switch debug-harness from token to code (#3418)
  pkgselect: Ensure path ends with slash (#3411)
  Suspense wrapper for ResourceCache (#3408)
  Make gendocs bash scripts fail loudly (#3414)
  Bump debian in /s3-proxy (#3415)
  Bump debian in /lambdas/thumbnail (#3416)
  Quilt3 v5.3.0 (#3413)
  Hotfix: status reports bucket exception (#3412)
  Add --no-copy parameter to Package.push() (#3398)
  Pin anndata to fix tests on Windows (#3410)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants