Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspense wrapper for ResourceCache #3408

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Suspense wrapper for ResourceCache #3408

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d72b8ba
Suspense wrapper for ResourceCache
fiskus Apr 10, 2023
1d846f6
add Changelog entry
fiskus Apr 10, 2023
ec00c58
Merge branch 'master' of github.com:quiltdata/quilt into voila-suspend
fiskus Apr 11, 2023
5166fce
return Pending and handle pending state consistently
fiskus Apr 11, 2023
52d8f33
Merge branch 'master' into voila-suspend
fiskus Apr 12, 2023
6944699
Merge branch 'master' into voila-suspend
fiskus Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion catalog/app/components/Preview/loaders/Notebook.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as R from 'ramda'
import * as React from 'react'
import * as M from '@material-ui/core'

import type * as Model from 'model'
import { PackageHandle } from 'utils/packageHandle'
Expand Down Expand Up @@ -53,5 +54,9 @@ export const Loader = function WrappedNotebookLoader({
handle,
children,
}: NotebookLoaderProps) {
return <NotebookLoader {...{ handle, children }} />
return (
<React.Suspense fallback={<M.CircularProgress />}>
<NotebookLoader {...{ handle, children }} />
</React.Suspense>
)
}
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Entries inside each section should be ordered by type:

## Catalog, Lambdas
* [Fixed] Fix package push failing for unrelated reason ([#3390](https://github.com/quiltdata/quilt/pull/3390))
* [Fixed] Fix package page flash when there is Jupyter Notebook ([#3408](https://github.com/quiltdata/quilt/pull/3408))

# 5.2.1 - 2023-04-05
## Python API
Expand Down