Prettify AwsMarketplace/Features.tsx and everything
#3319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3319 +/- ##
===========================================
+ Coverage 35.18% 81.28% +46.09%
===========================================
Files 674 31 -643
Lines 29331 2228 -27103
Branches 4336 0 -4336
===========================================
- Hits 10321 1811 -8510
+ Misses 17835 417 -17418
+ Partials 1175 0 -1175
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fiskus
changed the title
AwsMarketplace/Features.tsx and everything
* master: Cleaner syntax for pip install (add single quotes) (#3283) Prettify `AwsMarketplace/Features.tsx` and everything (#3319) Buttons refactoring (#3300) Landing for AWS Marketplace (#3251) Fix error message: `quilt login` => `quilt3 login` (#3316) Use code authorization flow instead of ID tokens. (#3296)
| window.opener.postMessage( | ||
| { type: 'callback', fragment: window.location.hash }, | ||
| window.location.origin, | ||
| ) |
There was a problem hiding this comment.
FYI, this file is served as is, without being compiled/processed, so this change could theoretically break things: the trailing comma was not supported before 2017: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas#browser_compatibility
(Maybe it should be compiled? I'm not sure how to set it up properly.)
There was a problem hiding this comment.
Thanks for this find!
I'll redefine prettier config for static directory, so it will use ES5 rules for commas
AwsMarketplace/Features.tsxthat slipped through in Landing for AWS Marketplace #3251cd catalog && npm run prettify .