Buttons refactoring #3300
Merged
Buttons refactoring #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3300 +/- ##
==========================================
+ Coverage 35.15% 35.18% +0.03%
==========================================
Files 676 674 -2
Lines 29358 29331 -27
Branches 4341 4336 -5
==========================================
Hits 10321 10321
+ Misses 17861 17835 -26
+ Partials 1176 1175 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nl0
previously approved these changes
Feb 1, 2023
|
Hmm..., Ok, I'll rename it to ButtonIconized, and move to Buttons again only when there will be one more button reused across app |
As i said, it's not a requirement and you can keep it as is if you feel like it would be better in perspective |
|
I mean, I agree, namespace Buttons will be reasonable when it contains at least two buttons |
nl0
approved these changes
Feb 2, 2023
nl0
added a commit
that referenced
this pull request
Feb 6, 2023
* master: Cleaner syntax for pip install (add single quotes) (#3283) Prettify `AwsMarketplace/Features.tsx` and everything (#3319) Buttons refactoring (#3300) Landing for AWS Marketplace (#3251) Fix error message: `quilt login` => `quilt3 login` (#3316) Use code authorization flow instead of ID tokens. (#3296)
akarve
pushed a commit
that referenced
this pull request
Feb 11, 2023
* Added icon to buttons "Create package from folder" and "Push to bucket" in desktop layout * Added components/Buttons/ButtonIconized, and replace FileView.AdaptiveLayoutButton * Removed components/ButtonIcon * Fix and unify margins
robnewman
pushed a commit
that referenced
this pull request
Apr 6, 2023
* Added icon to buttons "Create package from folder" and "Push to bucket" in desktop layout * Added components/Buttons/ButtonIconized, and replace FileView.AdaptiveLayoutButton * Removed components/ButtonIcon * Fix and unify margins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed:
flexWrap: 'wrap', see screenshot)Refactored:
components/Buttons/ButtonIconized, and replaceFileView.AdaptiveLayoutButtoncomponents/ButtonIcon. It was used only once, and it's trivial