Landing for AWS Marketplace #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3251 +/- ##
===========================================
+ Coverage 35.36% 88.83% +53.46%
===========================================
Files 668 79 -589
Lines 29184 9663 -19521
Branches 4326 0 -4326
===========================================
- Hits 10321 8584 -1737
+ Misses 17691 1079 -16612
+ Partials 1172 0 -1172
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
QuiltSimon
previously approved these changes
Jan 20, 2023
There was a problem hiding this comment.
I'll use this, if you don't mind https://resilience.com/wp-content/uploads/2021/11/Resilience-Logo.svg
Just fine.
I believe these are completed. Requesting rereview. |
QuiltSimon
previously approved these changes
Jan 30, 2023
QuiltSimon
approved these changes
Jan 30, 2023
akarve
requested review from
drernie and
akarve
and removed request for
akarve
|
Can someone show me which files contain the actual (new) marketing text for review? I'm getting bogged down... |
|
Features.tsx
Simon Kohnstamm
Director of Sales, Quilt Data, Inc.
***@***.*** | LinkedIn ( https://www.linkedin.com/in/simonrk/ )
(781) 277-2255
Manage Data Like Code
quiltdata.com ( https://quiltdata.com/ )
…On Wed, Feb 1 2023 at 8:46 PM, Dr. Ernie Prabhakar < ***@***.*** > wrote:
Can someone show me which files contain the actual (new) marketing text
for review? I'm getting bogged down...
—
Reply to this email directly, view it on GitHub (
#3251 (comment) ) , or
unsubscribe (
https://github.com/notifications/unsubscribe-auth/A33LN3HWQIETTSQIVQ6PIZTWVMGVTANCNFSM6AAAAAATVUPESA
).
You are receiving this because you were mentioned. Message ID: <quiltdata/quilt/pull/3251/c1413032444
@ github. com>
|
This is fine for now. We will probably want to revisit all the Marketing pages once we agree on a new "Positioning Statement", but we shouldn't let that block getting this out for ISVa. |
drernie
approved these changes
Feb 2, 2023
QuiltSimon
approved these changes
Feb 2, 2023
QuiltSimon
dismissed
akarve’s stale review
Changes employed and incorporated.
nl0
added a commit
that referenced
this pull request
Feb 6, 2023
* master: Cleaner syntax for pip install (add single quotes) (#3283) Prettify `AwsMarketplace/Features.tsx` and everything (#3319) Buttons refactoring (#3300) Landing for AWS Marketplace (#3251) Fix error message: `quilt login` => `quilt3 login` (#3316) Use code authorization flow instead of ID tokens. (#3296)
akarve
added a commit
that referenced
this pull request
Feb 11, 2023
Co-authored-by: Aneesh Karve <[email protected]> Co-authored-by: Simon Kohnstamm <[email protected]>
robnewman
pushed a commit
that referenced
this pull request
Apr 6, 2023
Co-authored-by: Aneesh Karve <[email protected]> Co-authored-by: Simon Kohnstamm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Changelog entryProbably, we should miss changelog entry here