Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOGITO-5289 Kogito DRL guide #19025

Merged
merged 1 commit into from
Aug 3, 2021
Merged

KOGITO-5289 Kogito DRL guide #19025

merged 1 commit into from
Aug 3, 2021

Conversation

lucamolteni
Copy link
Contributor

@lucamolteni lucamolteni commented Jul 27, 2021 •
edited
Loading

@lucamolteni lucamolteni mentioned this pull request Jul 27, 2021
Merged
10 tasks
jstastny-cz
jstastny-cz reviewed Jul 28, 2021
View reviewed changes
Copy link

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor wording comments. I still need to verify the steps using the actual quickstart, will update on that shortly.

docs/src/main/asciidoc/kogito-drl.adoc Outdated Show resolved Hide resolved
gsmet
gsmet requested changes Aug 3, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Spotted a couple of minor things.

docs/src/main/asciidoc/kogito-drl.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kogito-drl.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kogito-drl.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kogito-drl.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kogito-drl.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kogito-drl.adoc Outdated Show resolved Hide resolved
tarilabs
tarilabs reviewed Aug 3, 2021
View reviewed changes
Copy link
Contributor

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as spotted by #18904 (comment)

docs/src/main/asciidoc/kogito-drl.adoc Outdated Show resolved Hide resolved
@gsmet
Copy link
Member

gsmet commented Aug 3, 2021

All my comments are minor, I will finalize this one. Please don't push to it, thanks!

@gsmet
Copy link
Member

gsmet commented Aug 3, 2021

Everything fixed, let's wait for CI and merge.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 3, 2021
@gsmet gsmet merged commit 26729d7 into quarkusio:main Aug 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 3, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 3, 2021
@gsmet
Copy link
Member

gsmet commented Aug 3, 2021

Thanks!

@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstastny-cz jstastny-cz jstastny-cz left review comments

@tarilabs tarilabs tarilabs left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.1.1.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@lucamolteni @gsmet @tarilabs @jstastny-cz