Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-5560 remove 'preview'label from community website #18904

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

tarilabs
Copy link
Contributor

@gsmet
Copy link
Member

gsmet commented Jul 21, 2021

I don't think it makes sense to backport it past 2.0 as the older versions are using older versions of Kogito, so I suppose versions that should be considered preview still.

@tarilabs
Copy link
Contributor Author

We have Kogito runtime components from RHDM/RHPAM v7.11, which translates afaik to RHBQ equivalent of Quarkus-1.11, so I believe backport to Quarkus 1.11 inclusive, is indeed meaningful.

(
that's would have been the ~equivalent of

1.11 https://github.com/quarkusio/quarkus/pull/18905
1.12 https://github.com/quarkusio/quarkus/pull/18906
1.13 https://github.com/quarkusio/quarkus/pull/18907
2.0 https://github.com/quarkusio/quarkus/pull/18909
2.1 https://github.com/quarkusio/quarkus/pull/18910

)

@gsmet
Copy link
Member

gsmet commented Jul 21, 2021

Well, you will need a Quarkus Platform release to push the latest Kogito bits. I have no idea what's planned for this. I can mark it for backport but I have no idea if a new 1.11 will be released.

What's for sure is that we won't release any new 1.12 or 1.13.

@tarilabs
Copy link
Contributor Author

#18904 (comment) this is a bit beyond my radar, the intent here was actually to reflect the website guide, not code. I will follow-up in due time with the Kogito leads.

@danielezonca
Copy link
Contributor

@tarilabs
Thanks for the PR, I agree with @gsmet that main should be enough

@gsmet
Thanks for tracking it as possible backport for 1.11 but it should not be a big deal even if it will not be backported 👍

@tarilabs
Copy link
Contributor Author

/cc @evacchi

@tarilabs tarilabs marked this pull request as ready for review July 29, 2021 09:49
@tarilabs
Copy link
Contributor Author

This PR marked as ready following merge event on https://github.com/kiegroup/kogito-runtimes/pull/1462#event-5085007428

@gsmet gsmet merged commit 684fff0 into quarkusio:main Aug 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 3, 2021
@gsmet
Copy link
Member

gsmet commented Aug 3, 2021

@tarilabs just a note that the preview status has been added to the other guides you all created. Not sure if it should be dropped or not?

@tarilabs
Copy link
Contributor Author

tarilabs commented Aug 3, 2021

@gsmet you right, prediction and rule was missing to remove the Preview label, but AFAIK decision did not have Preview.

@tarilabs
Copy link
Contributor Author

tarilabs commented Aug 3, 2021

I have included comment in the related PRs with your spotting, thanks @gsmet

@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants