Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickstart for KOGITO-5289 Kogito DRL guide #911

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Quickstart for KOGITO-5289 Kogito DRL guide #911

merged 2 commits into from
Aug 3, 2021

Conversation

lucamolteni
Copy link
Contributor

@lucamolteni lucamolteni commented Jul 27, 2021 •
edited
Loading

quarkusio/quarkus#19025

cc @mariofusco @tarilabs @jstastny-cz @danielezonca
Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

@lucamolteni lucamolteni mentioned this pull request Jul 27, 2021
Merged
@tarilabs
Copy link
Contributor

tarilabs commented Jul 27, 2021 •
edited
Loading

(resolved)

@lucamolteni lucamolteni changed the base branch from main to development July 27, 2021 15:34
jstastny-cz
jstastny-cz reviewed Jul 28, 2021
View reviewed changes
Copy link

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're missing entry in root README.md as dictated by the PR template here.

@gsmet
Copy link
Member

gsmet commented Aug 3, 2021

I fixed a few minor things and force-pushed.

@gsmet
Copy link
Member

gsmet commented Aug 3, 2021

Let's wait for CI and merge (things went well locally).

@gsmet gsmet merged commit 62e578c into quarkusio:development Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstastny-cz jstastny-cz jstastny-cz left review comments

@gsmet gsmet gsmet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucamolteni @tarilabs @gsmet @jstastny-cz