Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus annotations not making sense on some Kubernetes resources #15598

Closed
ppatierno opened this issue Mar 10, 2021 · 2 comments · Fixed by #18989
Closed

Prometheus annotations not making sense on some Kubernetes resources #15598

ppatierno opened this issue Mar 10, 2021 · 2 comments · Fixed by #18989

Comments

@ppatierno
Copy link
Contributor

Hello,
while using the kubernetes extension and even adding the micrometer Prometheus registry one I noticed that the prometheus.io/ prefixed annotations are set on some resources where, AFAIK, don't make much sense.
I saw these annotations on ServiceAccount for example but even on Deployment. They really make more sense on Pod (but even deployment pod template) and on Service.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 10, 2021

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Mar 10, 2021

Indeed, that makes sense.

@iocanel I assume it's something that can be tackled relatively easily

@geoand geoand self-assigned this Jul 26, 2021
geoand added a commit to geoand/quarkus that referenced this issue Jul 26, 2021
geoand added a commit that referenced this issue Jul 28, 2021
Only add prometheus annotation and specific k8s resources
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 28, 2021
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants