Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus annotations not making sense on some Kubernetes resources #386

Closed
snowdrop-bot opened this issue Jul 26, 2021 · 0 comments
Closed

Prometheus annotations not making sense on some Kubernetes resources #386

snowdrop-bot opened this issue Jul 26, 2021 · 0 comments
Assignees
@geoand
Labels
7 - Community development upstream/closed The issue has been closed in the upstream repository

Comments

@snowdrop-bot
Copy link
Collaborator

Hello,
while using the kubernetes extension and even adding the micrometer Prometheus registry one I noticed that the prometheus.io/ prefixed annotations are set on some resources where, AFAIK, don't make much sense.
I saw these annotations on ServiceAccount for example but even on Deployment. They really make more sense on Pod (but even deployment pod template) and on Service.

quarkusio#15598

$upstream:15598$
@snowdrop-bot snowdrop-bot added the upstream/closed The issue has been closed in the upstream repository label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
7 - Community development upstream/closed The issue has been closed in the upstream repository
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geoand @snowdrop-bot