Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add prometheus annotation and specific k8s resources #18989

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Only add prometheus annotation and specific k8s resources #18989

merged 1 commit into from
Jul 28, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 26, 2021

Fixes: #15598

@geoand geoand requested a review from iocanel July 26, 2021 10:34
@geoand
Copy link
Contributor Author

geoand commented Jul 27, 2021 •
edited
Loading

@iocanel can I get a review of this please?

iocanel
iocanel approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geoand geoand merged commit fdddf2a into quarkusio:main Jul 28, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 28, 2021
@geoand geoand deleted the #15598 branch July 28, 2021 08:43
@geoand geoand mentioned this pull request Aug 2, 2021
Closed
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/kubernetes
Projects
None yet
Milestone
2.1.1.Final
Development

Successfully merging this pull request may close these issues.

Prometheus annotations not making sense on some Kubernetes resources
3 participants
@geoand @iocanel @gsmet