-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for 3.3 #47
Conversation
oldPropertyKey: quarkus.hibernate-search-orm.automatic_indexing.synchronization.strategy | ||
newPropertyKey: quarkus.hibernate-search-orm.indexing.plan.synchronization.strategy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that unfortunately, this won't work very well for YAML as OpenRewrite joins elements with dots which is not supported by SmallRye Config but that's the best we can do.
We have the problem with several other properties, we will have to live with it for now, I think.
There is an open issue here: openrewrite/rewrite#3426.
I tried to see if we could implement our own recipe but I somehow wasn't able to get OpenRewrite to find the constructor when our Java recipes have parameters (and I /think/ we have Lombok configured right).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which is not supported by SmallRye Config
That's the root of the problem IMO. Very annoying as a user. But it's been discussed before and it seems people working on Quarkus config disagree :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also quarkusio/quarkus#11744
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. My comments below.
Feel free to merge if you think the comments can be dismissed.
oldPropertyKey: quarkus.hibernate-search-orm.automatic_indexing.synchronization.strategy | ||
newPropertyKey: quarkus.hibernate-search-orm.indexing.plan.synchronization.strategy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which is not supported by SmallRye Config
That's the root of the problem IMO. Very annoying as a user. But it's been discussed before and it seems people working on Quarkus config disagree :/
@yrodiere I let you have a look.