Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for 3.3 #47

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add recipe for 3.3 #47

merged 1 commit into from
Aug 3, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 1, 2023

@yrodiere I let you have a look.

Comment on lines 30 to 33
oldPropertyKey: quarkus.hibernate-search-orm.automatic_indexing.synchronization.strategy
newPropertyKey: quarkus.hibernate-search-orm.indexing.plan.synchronization.strategy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that unfortunately, this won't work very well for YAML as OpenRewrite joins elements with dots which is not supported by SmallRye Config but that's the best we can do.
We have the problem with several other properties, we will have to live with it for now, I think.

There is an open issue here: openrewrite/rewrite#3426.

I tried to see if we could implement our own recipe but I somehow wasn't able to get OpenRewrite to find the constructor when our Java recipes have parameters (and I /think/ we have Lombok configured right).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is not supported by SmallRye Config

That's the root of the problem IMO. Very annoying as a user. But it's been discussed before and it seems people working on Quarkus config disagree :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. My comments below.

Feel free to merge if you think the comments can be dismissed.

Comment on lines 30 to 33
oldPropertyKey: quarkus.hibernate-search-orm.automatic_indexing.synchronization.strategy
newPropertyKey: quarkus.hibernate-search-orm.indexing.plan.synchronization.strategy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is not supported by SmallRye Config

That's the root of the problem IMO. Very annoying as a user. But it's been discussed before and it seems people working on Quarkus config disagree :/

recipes/src/main/resources/quarkus-updates/core/3.3.yaml Outdated Show resolved Hide resolved
recipes/src/main/resources/quarkus-updates/core/3.3.yaml Outdated Show resolved Hide resolved
@gsmet gsmet merged commit 84312e1 into quarkusio:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants